Source/core/rendering/svg/SVGTextRunRenderingContext.h - Issue 652483002: TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.h

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/svg/SVGTextMetricsBuilder.cpp ('k') | Source/core/rendering/svg/SVGTextRunRenderingContext.cpp » ('j') | Source/platform/fonts/Font.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/SVGTextRunRenderingContext.h

diff --git a/Source/core/rendering/svg/SVGTextRunRenderingContext.h b/Source/core/rendering/svg/SVGTextRunRenderingContext.h

index c91e8a1cc76a9a94acd9259fd80300e86515afad..46787aa5eda8c2664c4a22de8d99af858e9b1d43 100644

--- a/Source/core/rendering/svg/SVGTextRunRenderingContext.h

+++ b/Source/core/rendering/svg/SVGTextRunRenderingContext.h

@@ -41,11 +41,11 @@ public:

#if ENABLE(SVG_FONTS)

virtual GlyphData glyphDataForCharacter(const Font&, const TextRun&, SimpleShaper&, UChar32 character, bool mirror, int currentCharacter, unsigned& advanceLength) override;

virtual void drawSVGGlyphs(GraphicsContext*, const TextRun&, const SimpleFontData*, const GlyphBuffer&, int from, int to, const FloatPoint&) const override;

- virtual float floatWidthUsingSVGFont(const Font&, const TextRun&, int& charsConsumed, Glyph& glyphId) const override;

+ virtual float floatWidthUsingSVGFont(const Font&, const TextRun&, unsigned& charsConsumed, Glyph& glyphId) const override;

#else

virtual GlyphData glyphDataForCharacter(const Font&, const TextRun&, SimpleShaper&, UChar32 character, bool mirror, int currentCharacter, unsigned& advanceLength) override { return 0; }

virtual void drawSVGGlyphs(GraphicsContext*, const TextRun&, const SimpleFontData*, const GlyphBuffer&, int from, int to, const FloatPoint&) const override { }

- virtual float floatWidthUsingSVGFont(const Font&, const TextRun&, int& charsConsumed, Glyph& glyphId) const override { return 0; }

+ virtual float floatWidthUsingSVGFont(const Font&, const TextRun&, unsigned& charsConsumed, Glyph& glyphId) const override { return 0; }

#endif

private: