Source/core/rendering/svg/SVGTextMetricsBuilder.cpp - Issue 652483002: TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

diff --git a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

index 5f3cbf0ea0b6f1c7d3ea9a705291674a8be1d448..711aa32c23ef41d161c03960ff220718ffdb09e4 100644

--- a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

+++ b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

@@ -18,7 +18,6 @@

#include "config.h"

#include "core/rendering/svg/SVGTextMetricsBuilder.h"

#include "core/rendering/svg/RenderSVGInline.h"

@@ -43,7 +42,7 @@ public:

~SVGTextMetricsCalculator();

SVGTextMetrics computeMetricsForCharacter(unsigned textPosition);

- unsigned textLength() const { return static_cast<unsigned>(m_run.charactersLength()); }

+ unsigned textLength() const { return m_run.charactersLength(); }

bool characterStartsSurrogatePair(unsigned textPosition) const

{