Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/supervised_user/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=bauerb@chromium.org Committed: https://crrev.com/c072fff949cad2790f4cb731097c276897b37d0b Cr-Commit-Position: refs/heads/master@{#300460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -190 lines) Patch
M chrome/browser/supervised_user/custodian_profile_downloader_service.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/supervised_user/custodian_profile_downloader_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.h View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_sync.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_navigation_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_navigation_observer.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_mapping_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_mapping_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_refresh_token_fetcher.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_registration_utility.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_registration_utility_stub.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.h View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_shared_settings_service.h View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_shared_settings_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service.h View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_theme.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:39:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652473004/1
6 years, 2 months ago (2014-10-21 09:40:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:39:18 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:40:00 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c072fff949cad2790f4cb731097c276897b37d0b
Cr-Commit-Position: refs/heads/master@{#300460}

Powered by Google App Engine
This is Rietveld 408576698