chrome/browser/supervised_user/supervised_user_navigation_observer.cc - Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_navigation_observer.cc

Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_navigation_observer.h ('k') | chrome/browser/supervised_user/supervised_user_pref_mapping_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_navigation_observer.cc

diff --git a/chrome/browser/supervised_user/supervised_user_navigation_observer.cc b/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

index 655222d06a6c1e49ccd4dc66b032a67e251926d1..9114f47248d8b4985a26b0718e226ae51ec91e4b 100644

--- a/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

+++ b/chrome/browser/supervised_user/supervised_user_navigation_observer.cc

@@ -85,15 +85,15 @@ class SupervisedUserWarningInfoBarDelegate : public ConfirmInfoBarDelegate {

private:

SupervisedUserWarningInfoBarDelegate();

- virtual ~SupervisedUserWarningInfoBarDelegate();

+ ~SupervisedUserWarningInfoBarDelegate() override;

// ConfirmInfoBarDelegate:

- virtual bool ShouldExpire(const NavigationDetails& details) const override;

- virtual void InfoBarDismissed() override;

- virtual base::string16 GetMessageText() const override;

- virtual int GetButtons() const override;

- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;

- virtual bool Accept() override;

+ bool ShouldExpire(const NavigationDetails& details) const override;

+ void InfoBarDismissed() override;

+ base::string16 GetMessageText() const override;

+ int GetButtons() const override;

+ base::string16 GetButtonLabel(InfoBarButton button) const override;

+ bool Accept() override;

DISALLOW_COPY_AND_ASSIGN(SupervisedUserWarningInfoBarDelegate);

};