chrome/browser/supervised_user/supervised_user_navigation_observer.h - Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_navigation_observer.h

Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_interstitial.cc ('k') | chrome/browser/supervised_user/supervised_user_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_navigation_observer.h

diff --git a/chrome/browser/supervised_user/supervised_user_navigation_observer.h b/chrome/browser/supervised_user/supervised_user_navigation_observer.h

index a8772517ff900df290d117a9a4c5e6f532622e90..0b654c07667b8bec0836b854daa8db24367559f5 100644

--- a/chrome/browser/supervised_user/supervised_user_navigation_observer.h

+++ b/chrome/browser/supervised_user/supervised_user_navigation_observer.h

@@ -29,7 +29,7 @@ class SupervisedUserNavigationObserver

: public content::WebContentsObserver,

public content::WebContentsUserData<SupervisedUserNavigationObserver> {

public:

- virtual ~SupervisedUserNavigationObserver();

+ ~SupervisedUserNavigationObserver() override;

// Sets the specific infobar as dismissed.

void WarnInfoBarDismissed();

@@ -51,7 +51,7 @@ class SupervisedUserNavigationObserver

explicit SupervisedUserNavigationObserver(content::WebContents* web_contents);

// content::WebContentsObserver implementation.

- virtual void DidCommitProvisionalLoadForFrame(

+ void DidCommitProvisionalLoadForFrame(

content::RenderFrameHost* render_frame_host,

const GURL& url,

ui::PageTransition transition_type) override;