chrome/browser/supervised_user/supervised_user_pref_store.h - Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_pref_store.h

Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_pref_mapping_service_factory.h ('k') | chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_pref_store.h

diff --git a/chrome/browser/supervised_user/supervised_user_pref_store.h b/chrome/browser/supervised_user/supervised_user_pref_store.h

index 93b9a266837b1a139082be72ff3e1f55b95bbffd..c8a4e8128c4aa79f49a3270932e6c47ab3780e5f 100644

--- a/chrome/browser/supervised_user/supervised_user_pref_store.h

+++ b/chrome/browser/supervised_user/supervised_user_pref_store.h

@@ -28,15 +28,15 @@ class SupervisedUserPrefStore : public PrefStore {

SupervisedUserSettingsService* supervised_user_settings_service);

// PrefStore overrides:

- virtual bool GetValue(const std::string& key,

- const base::Value** value) const override;

- virtual void AddObserver(PrefStore::Observer* observer) override;

- virtual void RemoveObserver(PrefStore::Observer* observer) override;

- virtual bool HasObservers() const override;

- virtual bool IsInitializationComplete() const override;

+ bool GetValue(const std::string& key,

+ const base::Value** value) const override;

+ void AddObserver(PrefStore::Observer* observer) override;

+ void RemoveObserver(PrefStore::Observer* observer) override;

+ bool HasObservers() const override;

+ bool IsInitializationComplete() const override;

private:

- virtual ~SupervisedUserPrefStore();

+ ~SupervisedUserPrefStore() override;

void OnNewSettingsAvailable(const base::DictionaryValue* settings);