Input type attribue in radio button state with menu as parent should be exposed with correct IA2

Input type attribue in radio button state with menu as parent should be exposed with correct IA2

This is blink side CL to expose input type radio button with menu as parent with
correct IA2 role similar to aria role menuitemradio.

BUG=422879
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183622

[shreeramk, 2014-10-13 13:17:00]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, mkwst@chromium.org

[shreeramk, 2014-10-13 13:17:01]

Please review.

This CL would be followed up by chromium side CL.

Thanks!

[Mike West, 2014-10-13 13:42:40]

Code change LGTM % comments. Please wait for Dominic to sign off on the change
before landing it.

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:225: return MenuItemRadioRole;
The checkbox above is named CheckBoxMenuItemRole, while this is named
MenuItemRadioRole. I don't honestly care which you choose, but please be
consistent. :)

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXRenderObject.cpp (right):

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXRenderObject.cpp:335: return MenuItemRadioRole;
Ditto.

[dmazzoni, 2014-10-13 14:26:48]

lgtm

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/651893002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:225: return MenuItemRadioRole;
On 2014/10/13 13:42:40, Mike West wrote:
> The checkbox above is named CheckBoxMenuItemRole, while this is named
> MenuItemRadioRole. I don't honestly care which you choose, but please be
> consistent. :)

CheckBoxMenuItemRole was deleted in favor of MenuItemCheckBoxRole in an earlier
change that hasn't landed yet. Hopefully this will merge cleanly...

[shreeramk, 2014-10-13 18:07:33]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-13 18:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651893002/1

[commit-bot: I haz the power, 2014-10-13 19:04:23]

Committed patchset #1 (id:1) as 183622