Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 651893002: Input type attribue in radio button state with menu as parent should be exposed with correct IA2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 383cf33a981b70241fca1184d67fb5730a44b990..faa8cb45b792b281d734349b58885d77f98582af 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -220,8 +220,11 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
|| type == InputTypeNames::month
|| type == InputTypeNames::week)
return DateTimeRole;
- if (type == InputTypeNames::radio)
+ if (type == InputTypeNames::radio) {
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
+ return MenuItemRadioRole;
Mike West 2014/10/13 13:42:40 The checkbox above is named CheckBoxMenuItemRole,
dmazzoni 2014/10/13 14:26:48 CheckBoxMenuItemRole was deleted in favor of MenuI
return RadioButtonRole;
+ }
if (input.isTextButton())
return buttonRoleType();
if (type == InputTypeNames::range)
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | Source/core/accessibility/AXRenderObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698