Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 651893002: Input type attribue in radio button state with menu as parent should be exposed with correct IA2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 return CheckBoxMenuItemRole; 213 return CheckBoxMenuItemRole;
214 return CheckBoxRole; 214 return CheckBoxRole;
215 } 215 }
216 if (type == InputTypeNames::date) 216 if (type == InputTypeNames::date)
217 return DateRole; 217 return DateRole;
218 if (type == InputTypeNames::datetime 218 if (type == InputTypeNames::datetime
219 || type == InputTypeNames::datetime_local 219 || type == InputTypeNames::datetime_local
220 || type == InputTypeNames::month 220 || type == InputTypeNames::month
221 || type == InputTypeNames::week) 221 || type == InputTypeNames::week)
222 return DateTimeRole; 222 return DateTimeRole;
223 if (type == InputTypeNames::radio) 223 if (type == InputTypeNames::radio) {
224 if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode()) ) || (parentObject() && parentObject()->roleValue() == MenuRole))
225 return MenuItemRadioRole;
Mike West 2014/10/13 13:42:40 The checkbox above is named CheckBoxMenuItemRole,
dmazzoni 2014/10/13 14:26:48 CheckBoxMenuItemRole was deleted in favor of MenuI
224 return RadioButtonRole; 226 return RadioButtonRole;
227 }
225 if (input.isTextButton()) 228 if (input.isTextButton())
226 return buttonRoleType(); 229 return buttonRoleType();
227 if (type == InputTypeNames::range) 230 if (type == InputTypeNames::range)
228 return SliderRole; 231 return SliderRole;
229 if (type == InputTypeNames::color) 232 if (type == InputTypeNames::color)
230 return ColorWellRole; 233 return ColorWellRole;
231 if (type == InputTypeNames::time) 234 if (type == InputTypeNames::time)
232 return TimeRole; 235 return TimeRole;
233 return TextFieldRole; 236 return TextFieldRole;
234 } 237 }
(...skipping 1508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1743 float range = maxValueForRange() - minValueForRange(); 1746 float range = maxValueForRange() - minValueForRange();
1744 float value = valueForRange(); 1747 float value = valueForRange();
1745 1748
1746 value += range * (percentChange / 100); 1749 value += range * (percentChange / 100);
1747 setValue(String::number(value)); 1750 setValue(String::number(value));
1748 1751
1749 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e); 1752 axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, tru e);
1750 } 1753 }
1751 1754
1752 } // namespace blink 1755 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/accessibility/AXRenderObject.cpp » ('j') | Source/core/accessibility/AXRenderObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698