Source/core/accessibility/AXRenderObject.cpp - Issue 651893002: Input type attribue in radio button state with menu as parent should be exposed with correct IA2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 651893002: Input type attribue in radio button state with menu as parent should be exposed with correct IA2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXRenderObject.cpp

diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp

index 39bcf992bc8d194c679355cf346dd3016741916a..49bcfb22c082272830a1334855e87ba36d43625b 100644

--- a/Source/core/accessibility/AXRenderObject.cpp

+++ b/Source/core/accessibility/AXRenderObject.cpp

@@ -330,8 +330,11 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()

|| type == InputTypeNames::month

|| type == InputTypeNames::week)

return DateTimeRole;

- if (type == InputTypeNames::radio)

+ if (type == InputTypeNames::radio) {

+ if ((node->parentNode() && isHTMLMenuElement(node->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))

+ return MenuItemRadioRole;

Mike West 2014/10/13 13:42:40 Ditto.

return RadioButtonRole;

+ }

if (input.isTextButton())

return buttonRoleType();

if (type == InputTypeNames::color)

« Source/core/accessibility/AXNodeObject.cpp ('K') | « Source/core/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »