chrome/browser/profiles/profile_impl.cc - Issue 651443005: Use no-op statistics collecting object for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2

Patch Set: Selim and Ben's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_impl.cc

diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc

index 8ddd09e27d5235f0175fd6ef80bf2c61a1eb2cc0..fa33dcc09a2ba22419b5a997420409e93f9b718e 100644

--- a/chrome/browser/profiles/profile_impl.cc

+++ b/chrome/browser/profiles/profile_impl.cc

@@ -670,7 +670,7 @@ void ProfileImpl::DoFinalInit() {

g_browser_process->local_state(),

base::MessageLoopProxy::current(),

commit_delay));

- data_reduction_proxy_chrome_settings->SetDataReductionProxyStatisticsPrefs(

+ data_reduction_proxy_chrome_settings->SetDataReductionProxyStatistics(

sgurun-gerrit only 2014/10/17 20:29:38 same here. why change name?

bengr 2014/10/17 23:40:27 I like the name change, because the statistics obj

data_reduction_proxy_statistics_prefs.get());

// Make sure we initialize the ProfileIOData after everything else has been