chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc - Issue 651443005: Use no-op statistics collecting object for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2

Patch Set: Selim and Ben's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/net/aw_url_request_context_getter.cc ('K') | « android_webview/browser/net/aw_url_request_context_getter.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

index 8b52db2607e3c6731188cd4f00cc5e1390d148ac..4a5d62f368952d249eb2205a5768c848c53ea1e6 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

@@ -76,7 +76,7 @@ void data_reduction_proxy::DataReductionProxySettingsTestBase::ResetSettings(

EXPECT_CALL(*settings, GetURLFetcherForAvailabilityCheck()).Times(0);

EXPECT_CALL(*settings, LogProxyState(_, _, _)).Times(0);

settings_.reset(settings);

- settings_->SetDataReductionProxyStatisticsPrefs(statistics_prefs_.get());

+ settings_->SetDataReductionProxyStatistics(statistics_prefs_.get());

sgurun-gerrit only 2014/10/17 20:29:38 why change name?

hush (inactive) 2014/10/17 21:19:47 the idea of the base class "DataReductionProxyStat

}

template <class C>