Use no-op statistics collecting object for WebView

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
index c8b06e8c64d4d47e09a832cf95c806e87135ed9b..818c91b36527c7f90803ab1417b205619f8a6c5f 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
@@ -118,8 +118,8 @@ class DataReductionProxySettings
 
   // Sets the |statistics_prefs_| to be used for data reduction proxy pref reads
   // and writes.
-  void SetDataReductionProxyStatisticsPrefs(
-      DataReductionProxyStatisticsPrefs* statistics_prefs);
+  void SetDataReductionProxyStatistics(
+      DataReductionProxyStatistics* drp_statistics);

[bengr, 2014/10/17 23:40:27]

Don't use abbreviations like "drp". Can you just call this "statistics"?

[hush (inactive), 2014/10/18 02:09:15]

Done.

 
   // Sets the |on_data_reduction_proxy_enabled_| callback and runs to register
   // the DataReductionProxyEnabled synthetic field trial.
@@ -302,7 +302,15 @@ class DataReductionProxySettings
   BooleanPrefMember data_reduction_proxy_alternative_enabled_;
 
   PrefService* prefs_;
-  DataReductionProxyStatisticsPrefs* statistics_prefs_;
+  // This class manages the life time of |dummy_drp_statistics_| which is the
+  // default if the embedder does not call SetDataReductionProxyStatistics().
+  // The embedder who calls SetDataReductionProxyStatistics() manages the life
+  // time of |drp_statistics_|. In the case of chrome, ProfileImplIOData manages
+  // its lifetime.
+  // drp_statistics_ will be intialized as dummy_drp_statistics_ until
+  // SetDataReductionProxyStatistics is called.
+  scoped_ptr<DataReductionProxyStatistics> dummy_drp_statistics_;
+  DataReductionProxyStatistics* drp_statistics_;

[bengr, 2014/10/17 23:40:27]

I don't understand why you need two statistics pointers. Why can't Webview
manage the lifetime of its statistics object?

[hush (inactive), 2014/10/18 01:54:29]

From my discussion with Selim yesterday, I think our goal is to make
data_reduction_proxy and webview as loose coupled as possible. Since webview
does not care about stats gathering at the moment, I want to push the
responsibility of statistics object lifetime management to data_reduction_proxy
component. 

 
   net::URLRequestContextGetter* url_request_context_getter_;