Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/profiles/profile_impl.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2
Patch Set: Selim and Ben's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile_impl.h" 5 #include "chrome/browser/profiles/profile_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 base::TimeDelta commit_delay = base::TimeDelta(); 663 base::TimeDelta commit_delay = base::TimeDelta();
664 #else 664 #else
665 base::TimeDelta commit_delay = base::TimeDelta::FromMinutes(60); 665 base::TimeDelta commit_delay = base::TimeDelta::FromMinutes(60);
666 #endif 666 #endif
667 data_reduction_proxy_statistics_prefs = 667 data_reduction_proxy_statistics_prefs =
668 scoped_ptr<data_reduction_proxy::DataReductionProxyStatisticsPrefs>( 668 scoped_ptr<data_reduction_proxy::DataReductionProxyStatisticsPrefs>(
669 new data_reduction_proxy::DataReductionProxyStatisticsPrefs( 669 new data_reduction_proxy::DataReductionProxyStatisticsPrefs(
670 g_browser_process->local_state(), 670 g_browser_process->local_state(),
671 base::MessageLoopProxy::current(), 671 base::MessageLoopProxy::current(),
672 commit_delay)); 672 commit_delay));
673 data_reduction_proxy_chrome_settings->SetDataReductionProxyStatisticsPrefs( 673 data_reduction_proxy_chrome_settings->SetDataReductionProxyStatistics(
sgurun-gerrit only 2014/10/17 20:29:38 same here. why change name?
bengr 2014/10/17 23:40:27 I like the name change, because the statistics obj
674 data_reduction_proxy_statistics_prefs.get()); 674 data_reduction_proxy_statistics_prefs.get());
675 675
676 // Make sure we initialize the ProfileIOData after everything else has been 676 // Make sure we initialize the ProfileIOData after everything else has been
677 // initialized that we might be reading from the IO thread. 677 // initialized that we might be reading from the IO thread.
678 678
679 io_data_.Init(cookie_path, channel_id_path, cache_path, 679 io_data_.Init(cookie_path, channel_id_path, cache_path,
680 cache_max_size, media_cache_path, media_cache_max_size, 680 cache_max_size, media_cache_path, media_cache_max_size,
681 extensions_cookie_path, GetPath(), infinite_cache_path, 681 extensions_cookie_path, GetPath(), infinite_cache_path,
682 predictor_, session_cookie_mode, GetSpecialStoragePolicy(), 682 predictor_, session_cookie_mode, GetSpecialStoragePolicy(),
683 CreateDomainReliabilityMonitor(local_state), 683 CreateDomainReliabilityMonitor(local_state),
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1378 ProfileImpl::CreateDomainReliabilityMonitor(PrefService* local_state) { 1378 ProfileImpl::CreateDomainReliabilityMonitor(PrefService* local_state) {
1379 domain_reliability::DomainReliabilityService* service = 1379 domain_reliability::DomainReliabilityService* service =
1380 domain_reliability::DomainReliabilityServiceFactory::GetInstance()-> 1380 domain_reliability::DomainReliabilityServiceFactory::GetInstance()->
1381 GetForBrowserContext(this); 1381 GetForBrowserContext(this);
1382 if (!service) 1382 if (!service)
1383 return scoped_ptr<domain_reliability::DomainReliabilityMonitor>(); 1383 return scoped_ptr<domain_reliability::DomainReliabilityMonitor>();
1384 1384
1385 return service->CreateMonitor( 1385 return service->CreateMonitor(
1386 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)); 1386 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO));
1387 } 1387 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698