Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 651353004: SVGElement::parseAttribute resolves property via property map (Step 2.5) (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

SVGElement::parseAttribute resolves property via property map (Step 2.5) This CL moves SVGFitToViewBox hierarchy to parseAttributeNew. This is to replace the existing |SVGElement::parseAttribute| implementation, but as there are many callers, we would like to proceed this incrementally. a) Introduce |SVGElement::parseAttributeNew| *LANDED* b) Convert all overrides |SVGElement::parseAttribute| to a |parseAttributeNew| call. <-- This patch c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all overrides simply calling |parseAttributeNew| This patch is (b). BUG=397902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -90 lines) Patch
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +1 line, -21 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +1 line, -14 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 2 chunks +5 lines, -28 lines 0 comments Download
M Source/core/svg/SVGViewElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 chunk +2 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kouhei (in TOK)
6 years, 2 months ago (2014-10-17 04:10:55 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-17 04:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651353004/1
6 years, 2 months ago (2014-10-17 04:29:31 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 06:27:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183860

Powered by Google App Engine
This is Rietveld 408576698