Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Side by Side Diff: Source/core/svg/SVGViewElement.cpp

Issue 651353004: SVGElement::parseAttribute resolves property via property map (Step 2.5) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGViewElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 16 matching lines...) Expand all
27 inline SVGViewElement::SVGViewElement(Document& document) 27 inline SVGViewElement::SVGViewElement(Document& document)
28 : SVGElement(SVGNames::viewTag, document) 28 : SVGElement(SVGNames::viewTag, document)
29 , SVGFitToViewBox(this) 29 , SVGFitToViewBox(this)
30 , m_viewTarget(SVGStaticStringList::create(this, SVGNames::viewTargetAttr)) 30 , m_viewTarget(SVGStaticStringList::create(this, SVGNames::viewTargetAttr))
31 { 31 {
32 addToPropertyMap(m_viewTarget); 32 addToPropertyMap(m_viewTarget);
33 } 33 }
34 34
35 DEFINE_NODE_FACTORY(SVGViewElement) 35 DEFINE_NODE_FACTORY(SVGViewElement)
36 36
37 bool SVGViewElement::isSupportedAttribute(const QualifiedName& attrName)
38 {
39 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
40 if (supportedAttributes.isEmpty()) {
41 SVGFitToViewBox::addSupportedAttributes(supportedAttributes);
42 SVGZoomAndPan::addSupportedAttributes(supportedAttributes);
43 supportedAttributes.add(SVGNames::viewTargetAttr);
44 }
45 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
46 }
47
48 void SVGViewElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value) 37 void SVGViewElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value)
49 { 38 {
50 if (!isSupportedAttribute(name)) { 39 if (SVGZoomAndPan::parseAttribute(name, value))
51 SVGElement::parseAttribute(name, value);
52 return; 40 return;
53 }
54 41
55 SVGParsingError parseError = NoError; 42 parseAttributeNew(name, value);
56
57 if (SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
58 } else if (SVGZoomAndPan::parseAttribute(name, value)) {
59 } else if (name == SVGNames::viewTargetAttr) {
60 m_viewTarget->setBaseValueAsString(value, parseError);
61 } else {
62 ASSERT_NOT_REACHED();
63 }
64
65 reportAttributeParsingError(parseError, name, value);
66 } 43 }
67 44
68 } // namespace blink 45 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGViewElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698