Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: Source/core/svg/SVGSVGElement.cpp

Issue 651353004: SVGElement::parseAttribute resolves property via property map (Step 2.5) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGMarkerElement.cpp ('k') | Source/core/svg/SVGTextPositioningElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGSVGElement.cpp
diff --git a/Source/core/svg/SVGSVGElement.cpp b/Source/core/svg/SVGSVGElement.cpp
index 417ad8ee348ad2df3bd6df9fb544e58c7ead4ec2..89453ef06f06ef94e63ce6f25b593fcab98c7171 100644
--- a/Source/core/svg/SVGSVGElement.cpp
+++ b/Source/core/svg/SVGSVGElement.cpp
@@ -210,8 +210,6 @@ void SVGSVGElement::updateCurrentTranslate()
void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- SVGParsingError parseError = NoError;
-
if (!nearestViewportElement()) {
bool setListener = true;
@@ -235,21 +233,10 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString
document().setWindowAttributeEventListener(EventTypeNames::abort, createAttributeEventListener(document().frame(), name, value, eventParameterName()));
} else if (name == HTMLNames::onerrorAttr) {
document().setWindowAttributeEventListener(EventTypeNames::error, createAttributeEventListener(document().frame(), name, value, eventParameterName()));
- } else if (name == SVGNames::xAttr) {
- m_x->setBaseValueAsString(value, parseError);
- } else if (name == SVGNames::yAttr) {
- m_y->setBaseValueAsString(value, parseError);
- } else if (name == SVGNames::widthAttr) {
- m_width->setBaseValueAsString(value, parseError);
- } else if (name == SVGNames::heightAttr) {
- m_height->setBaseValueAsString(value, parseError);
- } else if (SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
} else if (SVGZoomAndPan::parseAttribute(name, value)) {
} else {
- SVGGraphicsElement::parseAttribute(name, value);
+ parseAttributeNew(name, value);
}
-
- reportAttributeParsingError(parseError, name, value);
}
bool SVGSVGElement::isPresentationAttribute(const QualifiedName& name) const
« no previous file with comments | « Source/core/svg/SVGMarkerElement.cpp ('k') | Source/core/svg/SVGTextPositioningElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698