Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: Source/core/svg/SVGMarkerElement.cpp

Issue 651353004: SVGElement::parseAttribute resolves property via property map (Step 2.5) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGMarkerElement.cpp
diff --git a/Source/core/svg/SVGMarkerElement.cpp b/Source/core/svg/SVGMarkerElement.cpp
index 61274d6496535f5f0c9a18b30f1d6e63ae2ecca9..88cef9cb58ec762b61023a62c0c32d6f77550fd4 100644
--- a/Source/core/svg/SVGMarkerElement.cpp
+++ b/Source/core/svg/SVGMarkerElement.cpp
@@ -86,27 +86,7 @@ bool SVGMarkerElement::isSupportedAttribute(const QualifiedName& attrName)
void SVGMarkerElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- SVGParsingError parseError = NoError;
-
- if (!isSupportedAttribute(name))
- SVGElement::parseAttribute(name, value);
- else if (name == SVGNames::markerUnitsAttr)
- m_markerUnits->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::refXAttr)
- m_refX->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::refYAttr)
- m_refY->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::markerWidthAttr)
- m_markerWidth->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::markerHeightAttr)
- m_markerHeight->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::orientAttr)
- m_orientAngle->setBaseValueAsString(value, parseError);
- else if (SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
- } else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
+ parseAttributeNew(name, value);
}
void SVGMarkerElement::svgAttributeChanged(const QualifiedName& attrName)
« no previous file with comments | « no previous file | Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698