Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 650903004: Update UI text. (Closed)

Created:
6 years, 2 months ago by Bence
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update UI text. Syntax of Privacy preferences within Advanced section follows the format at: https://support.google.com/chrome/answer/2392969 https://support.google.com/chrome/answer/2392971 https://support.google.com/chrome/answer/2392709 Note that this UI text is used by src/chrome/common/localized_error.cc. However, native code does not have access to internal Android strings like IDS_PREFERENCES, IDS_PREFS_SECTION_ADVANCED, IDS_PREFS_PRIVACY, IDS_NETWORK_PREDICTIONS_TITLE. Therefore unfortunately these strings must be hardcoded. TBR=cpu BUG=422314 Committed: https://crrev.com/eef8cdb3f9681b293feb0500f35534c462181b81 Cr-Commit-Position: refs/heads/master@{#302463}

Patch Set 1 #

Patch Set 2 : Fix unmatched tags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +20 lines, -10 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +20 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Bence
cpu: PTAL. Thank you.
6 years, 2 months ago (2014-10-24 15:26:40 UTC) #2
cpu_(ooo_6.6-7.5)
assuming UI folks are ok, you can always just TBR grd-only changes.
6 years, 1 month ago (2014-10-27 19:28:21 UTC) #3
Bence
On 2014/10/27 19:28:21, cpu wrote: > assuming UI folks are ok, you can always just ...
6 years, 1 month ago (2014-10-27 19:33:44 UTC) #4
Bence
On 2014/10/27 19:33:44, Bence wrote: > On 2014/10/27 19:28:21, cpu wrote: > > assuming UI ...
6 years, 1 month ago (2014-10-31 17:21:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650903004/1
6 years, 1 month ago (2014-10-31 17:22:35 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-31 17:22:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650903004/1
6 years, 1 month ago (2014-10-31 17:26:08 UTC) #11
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-10-31 17:27:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/86796) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/76404) android_chromium_gn_compile_rel ...
6 years, 1 month ago (2014-10-31 17:31:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650903004/80001
6 years, 1 month ago (2014-11-03 18:35:54 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 1 month ago (2014-11-03 19:28:58 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 19:29:40 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eef8cdb3f9681b293feb0500f35534c462181b81
Cr-Commit-Position: refs/heads/master@{#302463}

Powered by Google App Engine
This is Rietveld 408576698