Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 649783003: Force input coverage to be only a byte in gpu shaders. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Force input coverage to be only a byte in gpu shaders. Prime coverage invariant output calculations with single component BUG=skia: Committed: https://skia.googlesource.com/skia/+/37b4d866b1446d35c989f9a97885a777ddc7d1c8

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Updates #

Patch Set 4 : clean up #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -29 lines) Patch
M include/gpu/GrTypesPriv.h View 1 6 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 chunks +13 lines, -8 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
egdaniel
6 years, 1 month ago (2014-10-24 14:46:42 UTC) #2
bsalomon
https://codereview.chromium.org/649783003/diff/1/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/649783003/diff/1/src/gpu/GrDrawState.cpp#newcode392 src/gpu/GrDrawState.cpp:392: inout.fIsSingleComponent = true; I think it is time to ...
6 years, 1 month ago (2014-10-24 15:13:59 UTC) #3
egdaniel
updated so that we now enforce input coverage to be a single byte
6 years, 1 month ago (2014-10-31 20:29:03 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-11-03 15:06:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649783003/80001
6 years, 1 month ago (2014-11-03 17:58:35 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 37b4d866b1446d35c989f9a97885a777ddc7d1c8
6 years, 1 month ago (2014-11-03 18:07:11 UTC) #8
jcgregorio
6 years, 1 month ago (2014-11-05 19:51:02 UTC) #9
Message was sent while issue was closed.
On 2014/11/03 18:07:11, I haz the power (commit-bot) wrote:
> Committed patchset #5 (id:80001) as 37b4d866b1446d35c989f9a97885a777ddc7d1c8

Is this an expected performance change from this CL?

  https://skiaperf.com/#1262

Powered by Google App Engine
This is Rietveld 408576698