Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476)

Roll src/third_party/icu 8ac906f:d8b2a9d7 (svn 292317:292476)

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/8ac906f..6ea11f3

https://chromium.googlesource.com/chromium/deps/icu52/+log/6ea11f3..d8b2a9d

In addition, change the encoding menu, encoding preferences, and browser tests accordingly;
1. unify iso-8859-1 with windows-1252 in the menu (the name to use is windows-1252)
2. update the encoding preference (default encoding, etc) for various locales.
3. update the test result/expectation.

Re-enable tests disabled in https://codereview.chromium.org/643993004/

TBR=jsbell@chromium.org
BUG=412053
TEST=browser_tests
    BrowserEncodingTest.TestEncodingAutoDetect
    BrowserEncodingTest.TestOverrideEncoding
    EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping
    SavePageBrowserTest.FileNameFromPageTitle
    SavePageBrowserTest.SaveCompleteHTML
    PrefsTabHelperBrowserTest.WebPrefs
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
TEST=Blink: fast/encoding/*
TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-indexes
TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-aliases
TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-1253_test
TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-874_test

Committed: https://crrev.com/0f97763f80b69d6bb3fb974c63024de93e518c74
Cr-Commit-Position: refs/heads/master@{#300643}

[jungshik at Google, 2014-10-14 00:26:05]

jshin@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2014-10-15 00:46:43]

lgtm

[jungshik at Google, 2014-10-18 09:17:36]

jshin@chromium.org changed reviewers:
+ cpu@chromium.org, rdsmith@chromium.org, sky@chromium.org

[jungshik at Google, 2014-10-18 09:17:37]

cpu@chromium.org: Please review changes in chrome/app (command_id)

rdsmith@chromium.org: Please review changes in chrome/browser/download

sky@chromium.org: Please review changes in chrome/browser and chrome/brower/ui. 

Thanks !

[Randy Smith (Not in Mondays), 2014-10-20 14:11:03]

chrome/browser/download LGTM.

[cpu_(ooo_6.6-7.5), 2014-10-20 19:12:42]

if there is no license change you can TBR me.

lgtm

[sky, 2014-10-20 21:01:00]

https://codereview.chromium.org/649413002/diff/120001/chrome/browser/characte...
File chrome/browser/character_encoding.cc (right):

https://codereview.chromium.org/649413002/diff/120001/chrome/browser/characte...
chrome/browser/character_encoding.cc:392: break;
Why don't you return here? It means canonical_name can be moved inside the for
loop and we don't have to worry about what happens if array size is 0 and
canonical_name goes uninitialized.

[jungshik at Google, 2014-10-21 09:19:15]

On 2014/10/20 21:01:00, sky wrote:
>
https://codereview.chromium.org/649413002/diff/120001/chrome/browser/characte...
> File chrome/browser/character_encoding.cc (right):
> 
>
https://codereview.chromium.org/649413002/diff/120001/chrome/browser/characte...
> chrome/browser/character_encoding.cc:392: break;
> Why don't you return here? It means canonical_name can be moved inside the for
> loop and we don't have to worry about what happens if array size is 0 and
> canonical_name goes uninitialized.

Yeah.  Fixed in the latest PS. Can you take another look? THanks

[sky, 2014-10-21 18:01:47]

LGTM

[jungshik at Google, 2014-10-22 05:04:56]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2014-10-22 05:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649413002/110041

[commit-bot: I haz the power, 2014-10-22 06:51:48]

Committed patchset #9 (id:110041)

[commit-bot: I haz the power, 2014-10-22 06:53:38]

Patchset 9 (id:??) landed as
https://crrev.com/0f97763f80b69d6bb3fb974c63024de93e518c74
Cr-Commit-Position: refs/heads/master@{#300643}