chrome/browser/ui/browser_command_controller.cc - Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: space/indent fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index e6c7e5e980610f69db56171787ce81d16669c940..4c0c490ec399a119e6871f1c324effbe311d9cda 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -562,7 +562,6 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

break;

case IDC_ENCODING_UTF8:

case IDC_ENCODING_UTF16LE:

- case IDC_ENCODING_ISO88591:

case IDC_ENCODING_WINDOWS1252:

case IDC_ENCODING_GBK:

case IDC_ENCODING_GB18030:

@@ -909,7 +908,6 @@ void BrowserCommandController::InitCommandState() {

command_updater_.UpdateCommandEnabled(IDC_ENCODING_AUTO_DETECT, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_UTF8, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_UTF16LE, true);

- command_updater_.UpdateCommandEnabled(IDC_ENCODING_ISO88591, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_WINDOWS1252, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_GBK, true);

command_updater_.UpdateCommandEnabled(IDC_ENCODING_GB18030, true);

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/ui/toolbar/encoding_menu_controller.cc » ('j') | no next file with comments »