base/i18n/icu_string_conversions_unittest.cc - Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/icu_string_conversions_unittest.cc

Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: space/indent fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/i18n/icu_string_conversions_unittest.cc

diff --git a/base/i18n/icu_string_conversions_unittest.cc b/base/i18n/icu_string_conversions_unittest.cc

index 107e24096e4a734ba0956a58c8fee31e2455c76d..d4d32518575ce3a4280dd1c2861764fbf24656d3 100644

--- a/base/i18n/icu_string_conversions_unittest.cc

+++ b/base/i18n/icu_string_conversions_unittest.cc

@@ -343,7 +343,8 @@ static const struct {

{"foo-\xe4.html", "iso-8859-1", true, "foo-\xc3\xa4.html"},

{"foo-\xe4.html", "iso-8859-7", true, "foo-\xce\xb4.html"},

{"foo-\xe4.html", "foo-bar", false, ""},

- {"foo-\xff.html", "ascii", false, ""},

+ // HTML Encoding spec treats US-ASCII as synonymous with windows-1252

+ {"foo-\xff.html", "ascii", true, "foo-\xc3\xbf.html"},

{"foo.html", "ascii", true, "foo.html"},

{"foo-a\xcc\x88.html", "utf-8", true, "foo-\xc3\xa4.html"},

{"\x95\x32\x82\x36\xD2\xBB", "gb18030", true, "\xF0\xA0\x80\x80\xE4\xB8\x80"},

« no previous file with comments | « DEPS ('k') | chrome/app/chrome_command_ids.h » ('j') | no next file with comments »