chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc - Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

Issue 649413002: Roll src/third_party/icu 8ac906f:d8b2a9d (svn 292317:292476) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: space/indent fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/encoding_menu_controller.cc ('k') | chrome/test/data/encoding_tests/auto_detect/expected_results/expected_iso-8859-1_saved_from_no_encoding_specified.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

index ad6bd14245e47ba77ccd61837a94535d8809b0a2..c3dac40afbbcccd49969cc5b6968843e5e250a9b 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

@@ -199,5 +199,5 @@ class EncodingMenuModelTest : public BrowserWithTestWindowTest,

TEST_F(EncodingMenuModelTest, IsCommandIdCheckedWithNoTabs) {

EncodingMenuModel model(browser());

ASSERT_EQ(NULL, browser()->tab_strip_model()->GetActiveWebContents());

- EXPECT_FALSE(model.IsCommandIdChecked(IDC_ENCODING_ISO88591));

+ EXPECT_FALSE(model.IsCommandIdChecked(IDC_ENCODING_WINDOWS1252));

}