Devirtualize read/write pixels on surface.

Devirtualize read/write pixels on surface.

Consolidate read/write funcs in context.

Remove support for reading pixels from a surface that's not a target. It's currently broken and neither used nor tested.

Committed: https://skia.googlesource.com/skia/+/81beccc4fb1396fe94af15bfce26e68b82b93809

[bsalomon, 2014-10-13 13:15:14]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2014-10-13 13:37:33]

lgtm

lgtm

https://codereview.chromium.org/648863002/diff/240001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/648863002/diff/240001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1310: if (NULL == fp) {
sw_convert_to_premul ? Not sure though it could be messy with the
SkAutoSTMalloc.

[bsalomon, 2014-10-13 14:56:54]

https://codereview.chromium.org/648863002/diff/240001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/648863002/diff/240001/src/gpu/GrContext.cpp#n...
src/gpu/GrContext.cpp:1310: if (NULL == fp) {
On 2014/10/13 13:37:33, robertphillips wrote:
> sw_convert_to_premul ? Not sure though it could be messy with the
> SkAutoSTMalloc.

Done.

[bsalomon, 2014-10-13 14:56:58]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-10-13 14:57:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/648863002/370001

[commit-bot: I haz the power, 2014-10-13 19:33:00]

Committed patchset #6 (id:370001) as 81beccc4fb1396fe94af15bfce26e68b82b93809