Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 645063004: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: method changed: Node* V8GCController::opaqueRootForGC(Node* node, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/bindings/core/v8/V8GCController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
@haraken: NOTE: I am taking up the task function wise. Will increase the grouping of ...
6 years, 2 months ago (2014-10-20 09:54:24 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-20 10:46:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645063004/1
6 years, 2 months ago (2014-10-20 11:25:50 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 12:53:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183977

Powered by Google App Engine
This is Rietveld 408576698