Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

Issue 645063004: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8GCController.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp b/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp
index 1b2ae33f7c19062e8ff367335973e702ee8c2ecc..433f9b2074e92cc4e68a43949419384c6a5f9756 100644
--- a/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp
@@ -72,7 +72,7 @@ void V8MutationObserver::visitDOMWrapper(ScriptWrappableBase* internalPointer, c
MutationObserver* observer = internalPointer->toImpl<MutationObserver>();
WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes = observer->getObservedNodes();
for (WillBeHeapHashSet<RawPtrWillBeMember<Node> >::iterator it = observedNodes.begin(); it != observedNodes.end(); ++it) {
- v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootForGC(*it, isolate)));
+ v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootForGC(isolate, *it)));
isolate->SetReferenceFromGroup(id, wrapper);
}
}
« no previous file with comments | « Source/bindings/core/v8/V8GCController.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698