Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 645063004: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 if ({{set_wrapper_reference_to.name}}) { 581 if ({{set_wrapper_reference_to.name}}) {
582 if (!DOMDataStore::containsWrapper<{{set_wrapper_reference_to.v8_type}}> ({{set_wrapper_reference_to.name}}, isolate)) 582 if (!DOMDataStore::containsWrapper<{{set_wrapper_reference_to.v8_type}}> ({{set_wrapper_reference_to.name}}, isolate))
583 wrap({{set_wrapper_reference_to.name}}, creationContext, isolate); 583 wrap({{set_wrapper_reference_to.name}}, creationContext, isolate);
584 DOMDataStore::setWrapperReference<{{set_wrapper_reference_to.v8_type}}>( wrapper, {{set_wrapper_reference_to.name}}, isolate); 584 DOMDataStore::setWrapperReference<{{set_wrapper_reference_to.v8_type}}>( wrapper, {{set_wrapper_reference_to.name}}, isolate);
585 } 585 }
586 {% endfor %} 586 {% endfor %}
587 {% endif %} 587 {% endif %}
588 {% if reachable_node_function %} 588 {% if reachable_node_function %}
589 // The {{reachable_node_function}}() method may return a reference or a poin ter. 589 // The {{reachable_node_function}}() method may return a reference or a poin ter.
590 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) { 590 if (Node* owner = WTF::getPtr(impl->{{reachable_node_function}}())) {
591 Node* root = V8GCController::opaqueRootForGC(owner, isolate); 591 Node* root = V8GCController::opaqueRootForGC(isolate, owner);
592 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 592 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
593 return; 593 return;
594 } 594 }
595 {% endif %} 595 {% endif %}
596 setObjectGroup(internalPointer, wrapper, isolate); 596 setObjectGroup(internalPointer, wrapper, isolate);
597 } 597 }
598 598
599 {% endif %} 599 {% endif %}
600 {% endblock %} 600 {% endblock %}
601 601
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
895 {% endif %} 895 {% endif %}
896 } 896 }
897 897
898 template<> 898 template<>
899 v8::Handle<v8::Value> toV8NoInline({{cpp_class}}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate) 899 v8::Handle<v8::Value> toV8NoInline({{cpp_class}}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate)
900 { 900 {
901 return toV8(impl, creationContext, isolate); 901 return toV8(impl, creationContext, isolate);
902 } 902 }
903 903
904 {% endblock %} 904 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698