Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp - Issue 645063004: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

Issue 645063004: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/core/v8/V8GCController.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65	65

66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate());	66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate());

67 info.GetReturnValue().Set(wrapper);	67 info.GetReturnValue().Set(wrapper);

68 }	68 }

69	69

70 void V8MutationObserver::visitDOMWrapper(ScriptWrappableBase* internalPointer, c onst v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)	70 void V8MutationObserver::visitDOMWrapper(ScriptWrappableBase* internalPointer, c onst v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)

71 {	71 {

72 MutationObserver* observer = internalPointer->toImpl<MutationObserver>();	72 MutationObserver* observer = internalPointer->toImpl<MutationObserver>();

73 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes = observer->getOb servedNodes();	73 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes = observer->getOb servedNodes();

74 for (WillBeHeapHashSet<RawPtrWillBeMember<Node> >::iterator it = observedNod es.begin(); it != observedNodes.end(); ++it) {	74 for (WillBeHeapHashSet<RawPtrWillBeMember<Node> >::iterator it = observedNod es.begin(); it != observedNodes.end(); ++it) {

75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(*it, isolate)));	75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(isolate, *it)));

76 isolate->SetReferenceFromGroup(id, wrapper);	76 isolate->SetReferenceFromGroup(id, wrapper);

77 }	77 }

78 }	78 }

79	79

80 } // namespace blink	80 } // namespace blink

OLD	NEW