Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram… (Closed)

Created:
6 years, 2 months ago by aandrey
Modified:
6 years, 2 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call frame. BUG=415578, 110163 R=yurys, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184283

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -48 lines) Patch
M LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 chunk +2 lines, -2 lines 1 comment Download
A LayoutTests/inspector/sources/debugger/debugger-eval-on-call-frame-inside-iframe.html View 1 chunk +105 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-eval-on-call-frame-inside-iframe-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/DebuggerScript.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 14 chunks +29 lines, -31 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aandrey
6 years, 2 months ago (2014-10-23 10:48:35 UTC) #1
aandrey
https://codereview.chromium.org/644403003/diff/1/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt File LayoutTests/inspector/console/console-error-on-call-frame-expected.txt (right): https://codereview.chromium.org/644403003/diff/1/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt#newcode1 LayoutTests/inspector/console/console-error-on-call-frame-expected.txt:1: CONSOLE ERROR: line 1: 42 Finally after removing the ...
6 years, 2 months ago (2014-10-23 11:00:36 UTC) #2
pfeldman
lgtm
6 years, 2 months ago (2014-10-23 12:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644403003/1
6 years, 2 months ago (2014-10-23 14:17:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/14726)
6 years, 2 months ago (2014-10-23 14:23:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644403003/1
6 years, 2 months ago (2014-10-23 15:03:56 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 16:50:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184283

Powered by Google App Engine
This is Rietveld 408576698