Source/core/inspector/JavaScriptCallFrame.h - Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('K') | « Source/core/inspector/InjectedScriptSource.js ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/JavaScriptCallFrame.h

diff --git a/Source/core/inspector/JavaScriptCallFrame.h b/Source/core/inspector/JavaScriptCallFrame.h

index 2eb05d3abf2b82d4975b678b6c377bfeac65b4d3..2e34084410b375787ec75bd91569df20f8bfcc0d 100644

--- a/Source/core/inspector/JavaScriptCallFrame.h

+++ b/Source/core/inspector/JavaScriptCallFrame.h

@@ -68,7 +68,7 @@ public:

bool isAtReturn() const;

v8::Handle<v8::Value> returnValue() const;

- v8::Handle<v8::Value> evaluateWithExceptionDetails(const String& expression);

+ ScriptValue evaluateWithExceptionDetails(ScriptState*, const String& expression, const ScriptValue& scopeExtension);

v8::Handle<v8::Value> restart();

ScriptValue setVariableValue(ScriptState*, int scopeNumber, const String& variableName, const ScriptValue& newValue);