Source/bindings/core/v8/DebuggerScript.js - Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/DebuggerScript.js

Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('K') | « LayoutTests/inspector/sources/debugger/debugger-eval-on-call-frame-inside-iframe-expected.txt ('k') | Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/DebuggerScript.js

diff --git a/Source/bindings/core/v8/DebuggerScript.js b/Source/bindings/core/v8/DebuggerScript.js

index 695586874c2434e848972ee71d7c81babf9ba90e..1fc047bea482ae970719ce54387c2168bc725613 100644

--- a/Source/bindings/core/v8/DebuggerScript.js

+++ b/Source/bindings/core/v8/DebuggerScript.js

@@ -445,9 +445,9 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame, sc

return displayName || func.name() || func.inferredName();

}

- function evaluate(expression)

+ function evaluate(expression, scopeExtension)

{

- return frameMirror.evaluate(expression, false).value();

+ return frameMirror.evaluate(expression, false, scopeExtension).value();

}

function restart()