Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

Issue 644403003: DevTools: Fix __commandLineAPI is not defined error and remove the with- hack for eval on call fram… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "bindings/core/v8/V8JavaScriptCallFrame.h" 32 #include "bindings/core/v8/V8JavaScriptCallFrame.h"
33 33
34 #include "bindings/core/v8/V8Binding.h" 34 #include "bindings/core/v8/V8Binding.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 void V8JavaScriptCallFrame::evaluateWithExceptionDetailsMethodCustom(const v8::F unctionCallbackInfo<v8::Value>& info)
39 {
40 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toImpl(info.Holder());
41 String expression = toCoreStringWithUndefinedOrNullCheck(info[0]);
42 v8SetReturnValue(info, impl->evaluateWithExceptionDetails(expression));
43 }
44
45 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info) 38 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info)
46 { 39 {
47 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toImpl(info.Holder()); 40 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toImpl(info.Holder());
48 v8SetReturnValue(info, impl->restart()); 41 v8SetReturnValue(info, impl->restart());
49 } 42 }
50 43
51 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info) 44 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info)
52 { 45 {
53 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toImpl(info.Holder()); 46 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toImpl(info.Holder());
54 v8SetReturnValue(info, impl->scopeChain()); 47 v8SetReturnValue(info, impl->scopeChain());
(...skipping 18 matching lines...) Expand all
73 v8SetReturnValue(info, impl->returnValue()); 66 v8SetReturnValue(info, impl->returnValue());
74 } 67 }
75 68
76 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info) 69 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info)
77 { 70 {
78 v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "function")); 71 v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "function"));
79 } 72 }
80 73
81 } // namespace blink 74 } // namespace blink
82 75
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698