Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream, and its test. TEST=minidump_test MinidumpMemoryWriter.AddFromSnapshot R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4299ab3c4cdf70c8048ba12383b7a4cbf5c97f46

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+281 lines, -19 lines)			Patch
M	minidump/minidump_memory_writer.h	View		3 chunks	+23 lines, -0 lines	0 comments	Download
M	minidump/minidump_memory_writer.cc	View		2 chunks	+72 lines, -0 lines	0 comments	Download
M	minidump/minidump_memory_writer_test.cc	View	1	5 chunks	+61 lines, -2 lines	0 comments	Download
M	minidump/minidump_module_crashpad_info_writer.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	minidump/minidump_module_writer.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	minidump/minidump_module_writer_test.cc	View		1 chunk	+3 lines, -10 lines	0 comments	Download
M	snapshot/mac/memory_snapshot_mac.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	snapshot/memory_snapshot.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	snapshot/snapshot.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	snapshot/test/test_memory_snapshot.h	View		1 chunk	+60 lines, -0 lines	0 comments	Download
A	snapshot/test/test_memory_snapshot.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 1 month ago (2014-10-30 21:15:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4299ab3c4cdf70c8048ba12383b7a4cbf5c97f46 (presubmit successful).