Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test

minidump/minidump_module_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 631 matching lines @@
       module_type = ModuleSnapshot::kModuleTypeUnknown;
       break;
   }
   module_snapshot->SetModuleType(module_type);
 
   module_snapshot->SetUUID(uuid);
 }
 
 TEST(MinidumpModuleWriter, InitializeFromSnapshot) {
   MINIDUMP_MODULE expect_modules[3] = {};
-  const char* module_paths[3] = {};
-  const char* module_names[3] = {};
-  UUID uuids[3] = {};
-
-  static_assert(arraysize(expect_modules) == arraysize(module_paths),
-                "array sizes must be equal");
-  static_assert(arraysize(expect_modules) == arraysize(module_names),
-                "array sizes must be equal");
-  static_assert(arraysize(expect_modules) == arraysize(uuids),
-                "array sizes must be equal");
+  const char* module_paths[arraysize(expect_modules)] = {};
+  const char* module_names[arraysize(expect_modules)] = {};
+  UUID uuids[arraysize(expect_modules)] = {};
 
   expect_modules[0].BaseOfImage = 0x100101000;
   expect_modules[0].SizeOfImage = 0xf000;
   expect_modules[0].TimeDateStamp = 0x01234567;
   expect_modules[0].VersionInfo.dwFileVersionMS = 0x00010002;
   expect_modules[0].VersionInfo.dwFileVersionLS = 0x00030004;
   expect_modules[0].VersionInfo.dwProductVersionMS = 0x00050006;
   expect_modules[0].VersionInfo.dwProductVersionLS = 0x00070008;
   expect_modules[0].VersionInfo.dwFileType = VFT_APP;
   module_paths[0] = "/usr/bin/true";
@@ skipping 83 matching lines @@
   module_list_writer->AddModule(module_writer.Pass());
   minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "name_");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad