minidump/minidump_module_crashpad_info_writer.h - Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_crashpad_info_writer.h

Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Correctly look for the last memory range at EOF Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_module_crashpad_info_writer.h

diff --git a/minidump/minidump_module_crashpad_info_writer.h b/minidump/minidump_module_crashpad_info_writer.h

index 2db42a73e3644de06943a8ad54be9c5f88544af7..e9bc27921b1797df31f0186c0f23d4badc8c5ce6 100644

--- a/minidump/minidump_module_crashpad_info_writer.h

+++ b/minidump/minidump_module_crashpad_info_writer.h

@@ -113,9 +113,9 @@ class MinidumpModuleCrashpadInfoListWriter final

//!

//! \param[in] module_snapshots The module snapshots to use as source data.

//!

- //! \note Valid in #kStateMutable. AddModule() may not be called before this

- //! method, and it is not normally necessary to call AddModule() after

- //! this method.

+ //! \note Valid in #kStateMutable. No mutator methods may be called before

+ //! this method, and it is not normally necessary to call any mutator

+ //! methods after this method.

void InitializeFromSnapshot(

const std::vector<const ModuleSnapshot*>& module_snapshots);

« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_module_writer.h » ('j') | no next file with comments »