snapshot/memory_snapshot.h - Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/memory_snapshot.h

Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Correctly look for the last memory range at EOF Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/memory_snapshot.h

diff --git a/snapshot/memory_snapshot.h b/snapshot/memory_snapshot.h

index f00610812eec8160a9040e33fd70c6604f6c0cc9..47f8443e617b7a7840f0ad1112514d7d234eb17f 100644

--- a/snapshot/memory_snapshot.h

+++ b/snapshot/memory_snapshot.h

@@ -39,7 +39,8 @@ class MemorySnapshot {

//!

//! \param[in] data A pointer to the data that was read. The callee does not

//! take ownership of this data. This data is only valid for the

- //! duration of the call to this method.

+ //! duration of the call to this method. This parameter may be `nullptr`

+ //! if \a size is `0`.

//! \param[in] size The size of the data that was read.

//!

//! \return `true` on success, `false` on failure. MemoryDelegate::Read()

« no previous file with comments | « snapshot/mac/memory_snapshot_mac.cc ('k') | snapshot/snapshot.gyp » ('j') | no next file with comments »