Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten… (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME extensions can know about the composition bounds. BUG=424922 TEST=Verified on linux_chromeos. Committed: https://crrev.com/21872f1e6671593706435de8cb78412ec6f4ad7d Cr-Commit-Position: refs/heads/master@{#301279}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits + unit test #

Messages

Total messages: 10 (2 generated)
Shu Chen
Guys, can you please review this cl? Thanks yukishiino@: overall IMF. kalman@: chrome/common/extensions/api/input_method_private.json
6 years, 2 months ago (2014-10-24 08:42:13 UTC) #2
Yuki
lgtm. https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc File chrome/browser/chromeos/input_method/input_method_engine_unittest.cc (right): https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc#newcode100 chrome/browser/chromeos/input_method/input_method_engine_unittest.cc:100: virtual void OnCompositionBoundsChanged(const gfx::Rect& bounds) override {} It ...
6 years, 2 months ago (2014-10-24 09:52:34 UTC) #3
Shu Chen
https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc File chrome/browser/chromeos/input_method/input_method_engine_unittest.cc (right): https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc#newcode100 chrome/browser/chromeos/input_method/input_method_engine_unittest.cc:100: virtual void OnCompositionBoundsChanged(const gfx::Rect& bounds) override {} On 2014/10/24 ...
6 years, 2 months ago (2014-10-24 15:38:06 UTC) #4
not at google - send to devlin
6 years, 2 months ago (2014-10-24 20:33:39 UTC) #5
not at google - send to devlin
oops, lgtm. Also see https://codereview.chromium.org/673163005.
6 years, 2 months ago (2014-10-24 20:33:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641243005/20001
6 years, 2 months ago (2014-10-25 06:19:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-25 07:10:40 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 07:11:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21872f1e6671593706435de8cb78412ec6f4ad7d
Cr-Commit-Position: refs/heads/master@{#301279}

Powered by Google App Engine
This is Rietveld 408576698