Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten…

Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME extensions can know about the composition bounds.

BUG=424922
TEST=Verified on linux_chromeos.

Committed: https://crrev.com/21872f1e6671593706435de8cb78412ec6f4ad7d
Cr-Commit-Position: refs/heads/master@{#301279}

[Shu Chen, 2014-10-24 08:42:12]

shuchen@chromium.org changed reviewers:
+ kalman@chromium.org, yukishiino@chromium.org

[Shu Chen, 2014-10-24 08:42:13]

Guys, can you please review this cl? Thanks

yukishiino@: overall IMF.

kalman@: chrome/common/extensions/api/input_method_private.json

[Yuki, 2014-10-24 09:52:34]

lgtm.

https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_engine_unittest.cc
(right):

https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_engine_unittest.cc:100:
virtual void OnCompositionBoundsChanged(const gfx::Rect& bounds) override {}
It would be great if we can have a test.
Very very simple one satisfies.

https://codereview.chromium.org/641243005/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/641243005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:110: if
(extension_id_.empty() || !HasListener(
nit: Better to break at greater level (shallower level) in general.
if (extension_id_.empty() ||
    !HasListener(input_ime::OnActivate::kEventName))

Ditto for the same change below.

[Shu Chen, 2014-10-24 15:38:06]

https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_engine_unittest.cc
(right):

https://codereview.chromium.org/641243005/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_engine_unittest.cc:100:
virtual void OnCompositionBoundsChanged(const gfx::Rect& bounds) override {}
On 2014/10/24 09:52:33, Yuki wrote:
> It would be great if we can have a test.
> Very very simple one satisfies.

Done.

https://codereview.chromium.org/641243005/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/641243005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:110: if
(extension_id_.empty() || !HasListener(
On 2014/10/24 09:52:33, Yuki wrote:
> nit: Better to break at greater level (shallower level) in general.
> if (extension_id_.empty() ||
>     !HasListener(input_ime::OnActivate::kEventName))
> 
> Ditto for the same change below.

Done.

[not at google - send to devlin, 2014-10-24 20:33:49]

oops, lgtm.

Also see https://codereview.chromium.org/673163005.

[Shu Chen, 2014-10-25 06:18:43]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-10-25 06:19:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641243005/20001

[commit-bot: I haz the power, 2014-10-25 07:10:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-25 07:11:29]

Patchset 2 (id:??) landed as
https://crrev.com/21872f1e6671593706435de8cb78412ec6f4ad7d
Cr-Commit-Position: refs/heads/master@{#301279}