Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits + unit test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/input_method/input_method_engine.h" 5 #include "chrome/browser/chromeos/input_method/input_method_engine.h"
6 6
7 #undef FocusIn 7 #undef FocusIn
8 #undef FocusOut 8 #undef FocusOut
9 #undef RootWindow 9 #undef RootWindow
10 #include <map> 10 #include <map>
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 504
505 void InputMethodEngine::HideInputView() { 505 void InputMethodEngine::HideInputView() {
506 keyboard::KeyboardController* keyboard_controller = 506 keyboard::KeyboardController* keyboard_controller =
507 keyboard::KeyboardController::GetInstance(); 507 keyboard::KeyboardController::GetInstance();
508 if (keyboard_controller) { 508 if (keyboard_controller) {
509 keyboard_controller->HideKeyboard( 509 keyboard_controller->HideKeyboard(
510 keyboard::KeyboardController::HIDE_REASON_MANUAL); 510 keyboard::KeyboardController::HIDE_REASON_MANUAL);
511 } 511 }
512 } 512 }
513 513
514 void InputMethodEngine::SetCompositionBounds(const gfx::Rect& bounds) {
515 observer_->OnCompositionBoundsChanged(bounds);
516 }
517
514 void InputMethodEngine::EnableInputView() { 518 void InputMethodEngine::EnableInputView() {
515 #if defined(USE_ATHENA) 519 #if defined(USE_ATHENA)
516 // Athena does not currently support an extension-based VK. Blocking the 520 // Athena does not currently support an extension-based VK. Blocking the
517 // override forces Athena to use to the system fallback VK, without 521 // override forces Athena to use to the system fallback VK, without
518 // interfering with the rest of the IME system. 522 // interfering with the rest of the IME system.
519 // TODO(shuchen|kevers): Remove override suppression once supported. 523 // TODO(shuchen|kevers): Remove override suppression once supported.
520 // See crbug/407579, crbug/414940 and crbug/418078. 524 // See crbug/407579, crbug/414940 and crbug/418078.
521 NOTIMPLEMENTED(); 525 NOTIMPLEMENTED();
522 #else 526 #else
523 keyboard::SetOverrideContentUrl(input_method::InputMethodManager::Get() 527 keyboard::SetOverrideContentUrl(input_method::InputMethodManager::Get()
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 // TODO(nona): Implement it. 694 // TODO(nona): Implement it.
691 break; 695 break;
692 } 696 }
693 } 697 }
694 } 698 }
695 699
696 // TODO(nona): Support item.children. 700 // TODO(nona): Support item.children.
697 } 701 }
698 702
699 } // namespace chromeos 703 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698