chrome/browser/chromeos/input_method/input_method_engine.cc - Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits + unit test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.h ('k') | chrome/browser/chromeos/input_method/input_method_engine_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc

index d7e48fbb723abd3236025e31dd26838fddb64632..6a1dfed608643405d1c99c73cd16b58c294bf7c2 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc

@@ -511,6 +511,10 @@ void InputMethodEngine::HideInputView() {

}

+void InputMethodEngine::SetCompositionBounds(const gfx::Rect& bounds) {

+ observer_->OnCompositionBoundsChanged(bounds);

void InputMethodEngine::EnableInputView() {

#if defined(USE_ATHENA)

// Athena does not currently support an extension-based VK. Blocking the