Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 673163005: Add shuchen@ and yukishiino@ as OWNERS for input_method_private.json. (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 1 month ago
Reviewers:
Shu Chen, Yuki
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add shuchen@ and yukishiino@ as OWNERS for input_method_private.json. R=shuchen@chromium.org, yukishiino@chromium.org Committed: https://crrev.com/9fb02c74d6ae67cdf88c965da6566144d39a333e Cr-Commit-Position: refs/heads/master@{#301291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/common/extensions/api/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
not at google - send to devlin
This is a private API so there's not much value in waiting for my lg ...
6 years, 2 months ago (2014-10-24 20:34:46 UTC) #2
Shu Chen
lgtm. Thanks for putting Yuki/me as OWNER which will save the review round trips. Can ...
6 years, 1 month ago (2014-10-25 06:18:26 UTC) #3
not at google - send to devlin
Thanks. I'm adding you as owners for the private API because private APIs don't require ...
6 years, 1 month ago (2014-10-25 18:16:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673163005/1
6 years, 1 month ago (2014-10-25 18:17:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 19:01:22 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 19:02:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb02c74d6ae67cdf88c965da6566144d39a333e
Cr-Commit-Position: refs/heads/master@{#301291}

Powered by Google App Engine
This is Rietveld 408576698