Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 640593003: Remove the sender_id from the Push API code path. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Remove the sender_id from the Push API code path. The sender Id will be read from the manifest rather than taken as an argument to the push.register() JavaScript call. Stop passing it through. BUG=424601 Committed: https://crrev.com/95d42291602b051425eec0173a5870bbb9ba46c2 Cr-Commit-Position: refs/heads/master@{#301222}

Patch Set 1 #

Patch Set 2 : add manifest #

Patch Set 3 : add TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/push_messaging/manifest.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/push_messaging/test.html View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/push_messaging_dispatcher.h View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/push_messaging_dispatcher.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Peter Beverloo
PTAL
6 years, 2 months ago (2014-10-17 14:47:59 UTC) #2
Mike West
content/shell LGTM. If you intend to remove the old signature, please add a '// TODO(peter):' ...
6 years, 2 months ago (2014-10-18 12:06:47 UTC) #4
Michael van Ouwerkerk
lgtm Thanks Peter! Please land this after https://crrev.com/648623003/ - you'll need to make some changes ...
6 years, 2 months ago (2014-10-20 16:38:27 UTC) #5
Peter Beverloo
I added a manifest to the browser_test, which successfully passes. fgorski: PTAL at //c/b/s/gcm/push_messaging_browsertest.cc. sievers: ...
6 years, 2 months ago (2014-10-24 15:43:28 UTC) #7
Peter Beverloo
+sievers
6 years, 2 months ago (2014-10-24 15:43:40 UTC) #9
fgorski
lgtm
6 years, 2 months ago (2014-10-24 17:14:50 UTC) #10
no sievers
lgtm
6 years, 2 months ago (2014-10-24 18:18:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640593003/40001
6 years, 2 months ago (2014-10-24 22:06:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-24 23:10:42 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 23:11:20 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95d42291602b051425eec0173a5870bbb9ba46c2
Cr-Commit-Position: refs/heads/master@{#301222}

Powered by Google App Engine
This is Rietveld 408576698