Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: content/renderer/push_messaging_dispatcher.h

Issue 640593003: Remove the sender_id from the Push API code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: add TODOs Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/push_messaging/test.html ('k') | content/renderer/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging_dispatcher.h b/content/renderer/push_messaging_dispatcher.h
index 080510fc6c63edd7c67c90ea8791d93fdae0c466..de9f8c97a71ab20b93f620597ea5688e0bb0588d 100644
--- a/content/renderer/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging_dispatcher.h
@@ -38,13 +38,16 @@ class PushMessagingDispatcher : public RenderFrameObserver,
bool OnMessageReceived(const IPC::Message& message) override;
// WebPushClient implementation.
+ // TODO(peter): Remove this signature of registerPushMessaging.
virtual void registerPushMessaging(
const blink::WebString& sender_id,
blink::WebPushRegistrationCallbacks* callbacks,
blink::WebServiceWorkerProvider* service_worker_provider);
+ virtual void registerPushMessaging(
+ blink::WebPushRegistrationCallbacks* callbacks,
+ blink::WebServiceWorkerProvider* service_worker_provider);
- void DoRegister(const std::string& sender_id,
- blink::WebPushRegistrationCallbacks* callbacks,
+ void DoRegister(blink::WebPushRegistrationCallbacks* callbacks,
blink::WebServiceWorkerProvider* service_worker_provider,
const Manifest& manifest);
« no previous file with comments | « chrome/test/data/push_messaging/test.html ('k') | content/renderer/push_messaging_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698