content/shell/renderer/test_runner/mock_web_push_client.h - Issue 640593003: Remove the sender_id from the Push API code path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/mock_web_push_client.h

Issue 640593003: Remove the sender_id from the Push API code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: add TODOs Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/mock_web_push_client.h

diff --git a/content/shell/renderer/test_runner/mock_web_push_client.h b/content/shell/renderer/test_runner/mock_web_push_client.h

index 9c9f48c75e10ca0bcf18137d676aac8eef2346ca..7a1c5a685e68a1039263c935fbcecb1ea1c00e4e 100644

--- a/content/shell/renderer/test_runner/mock_web_push_client.h

+++ b/content/shell/renderer/test_runner/mock_web_push_client.h

@@ -37,9 +37,9 @@ class MockWebPushClient : public blink::WebPushClient {

// WebPushClient implementation.

virtual void registerPushMessaging(

const blink::WebString& sender_id,

- blink::WebPushRegistrationCallbacks* callbacks);

+ blink::WebPushRegistrationCallbacks* callbacks,

+ blink::WebServiceWorkerProvider* service_worker_provider);

virtual void registerPushMessaging(

- const blink::WebString& sender_id,

blink::WebPushRegistrationCallbacks* callbacks,

blink::WebServiceWorkerProvider* service_worker_provider);