chrome/test/data/push_messaging/test.html - Issue 640593003: Remove the sender_id from the Push API code path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/push_messaging/test.html

Issue 640593003: Remove the sender_id from the Push API code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: add TODOs Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/push_messaging/test.html

diff --git a/chrome/test/data/push_messaging/test.html b/chrome/test/data/push_messaging/test.html

index 407695698f89695224c755778a9469741c1da770..1a3bd65213324bd34421982620227f3d9f061647 100644

--- a/chrome/test/data/push_messaging/test.html

+++ b/chrome/test/data/push_messaging/test.html

@@ -2,6 +2,7 @@

<html>

<head>

+ <link rel="manifest" href="manifest.json">

function sendResultToTest(result) {

console.log(result);

@@ -21,9 +22,10 @@

}, sendErrorToTest);

}

- function registerPush(senderId) {

+ function registerPush() {

navigator.serviceWorker.ready.then(function() {

- navigator.push.register(senderId).then(function(pushRegistration) {

+ // TODO(peter): Remove the argument once Blink no longer requires it.

+ navigator.push.register('DEPRECATED').then(function(pushRegistration) {

sendResultToTest(pushRegistration.pushEndpoint + ' - ' + pushRegistration.pushRegistrationId);

}, sendErrorToTest);