Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

In tests, use ASSERT_NO_FATAL_FAILURE() instead of checking testing::Test::HasFatalFailure() after calling functions that could fail fatally. Inspired by https://codereview.chromium.org/637503006/diff/20001/minidump/minidump_thread_writer_test.cc#newcode437 TEST=client_test, minidump_test, util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/22350bd67657acd11c62127a132b3d403396bda5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -367 lines) Patch
M client/capture_context_mac_test.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M minidump/minidump_file_writer_test.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 5 chunks +9 lines, -20 lines 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 13 chunks +13 lines, -52 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 11 chunks +89 lines, -126 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 5 chunks +9 lines, -22 lines 0 comments Download
M util/mac/mac_util_test.mm View 2 chunks +5 lines, -13 lines 0 comments Download
M util/mac/mach_o_image_reader_test.cc View 9 chunks +25 lines, -52 lines 0 comments Download
M util/mac/process_reader_test.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 1 chunk +1 line, -4 lines 0 comments Download
M util/test/multiprocess.h View 1 chunk +1 line, -4 lines 0 comments Download
M util/test/multiprocess.cc View 1 chunk +1 line, -4 lines 0 comments Download
M util/test/multiprocess_exec.cc View 1 chunk +1 line, -4 lines 0 comments Download
M util/test/multiprocess_test.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-09 18:56:14 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-09 19:06:11 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-09 19:08:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
22350bd67657acd11c62127a132b3d403396bda5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698