Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: util/test/multiprocess.h

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/test/mac/mach_multiprocess.cc ('k') | util/test/multiprocess.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/test/multiprocess.h
diff --git a/util/test/multiprocess.h b/util/test/multiprocess.h
index 781ec7c13a2fe88eeb6c60e4d26ef0760b5f5268..c4eadde3caaa9df0bef0cb5740280ef7e1714a55 100644
--- a/util/test/multiprocess.h
+++ b/util/test/multiprocess.h
@@ -93,10 +93,7 @@ class Multiprocess {
//!
//! \code
//! virtual void PreFork() override {
- //! Multiprocess::PreFork();
- //! if (testing::Test::HasFatalFailure()) {
- //! return;
- //! }
+ //! ASSERT_NO_FATAL_FAILURE(Multiprocess::PreFork());
//!
//! // Place subclass-specific pre-fork code here.
//! }
« no previous file with comments | « util/test/mac/mach_multiprocess.cc ('k') | util/test/multiprocess.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698