Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: util/test/multiprocess_test.cc

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/test/multiprocess_exec.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/test/multiprocess_test.cc
diff --git a/util/test/multiprocess_test.cc b/util/test/multiprocess_test.cc
index ec4394e0d2544783eee246600bce0840c67698bd..a766585462263806550d36ff0f699c4e1e65b97b 100644
--- a/util/test/multiprocess_test.cc
+++ b/util/test/multiprocess_test.cc
@@ -217,10 +217,7 @@ class TestMultiprocessClosePipe final : public Multiprocess {
// Multiprocess:
virtual void MultiprocessParent() override {
- VerifyInitial();
- if (testing::Test::HasFatalFailure()) {
- return;
- }
+ ASSERT_NO_FATAL_FAILURE(VerifyInitial());
if (who_closes_ == kParentCloses) {
Close();
@@ -230,10 +227,7 @@ class TestMultiprocessClosePipe final : public Multiprocess {
}
virtual void MultiprocessChild() override {
- VerifyInitial();
- if (testing::Test::HasFatalFailure()) {
- return;
- }
+ ASSERT_NO_FATAL_FAILURE(VerifyInitial());
if (who_closes_ == kChildCloses) {
Close();
« no previous file with comments | « util/test/multiprocess_exec.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698