Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: client/capture_context_mac_test.cc

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/capture_context_mac_test.cc
diff --git a/client/capture_context_mac_test.cc b/client/capture_context_mac_test.cc
index 3dc0ba8dabc1e80e21c4c238cf27396a822e58c7..6d5967d5f470d14e9270aeab56e59096b97ac50e 100644
--- a/client/capture_context_mac_test.cc
+++ b/client/capture_context_mac_test.cc
@@ -95,10 +95,7 @@ void TestCaptureContext() {
{
SCOPED_TRACE("context_1");
- SanityCheckContext(&context_1);
- }
- if (testing::Test::HasFatalFailure()) {
- return;
+ ASSERT_NO_FATAL_FAILURE(SanityCheckContext(&context_1));
}
// The program counter reference value is this function’s address. The
@@ -134,10 +131,7 @@ void TestCaptureContext() {
{
SCOPED_TRACE("context_2");
- SanityCheckContext(&context_2);
- }
- if (testing::Test::HasFatalFailure()) {
- return;
+ ASSERT_NO_FATAL_FAILURE(SanityCheckContext(&context_2));
}
EXPECT_EQ(sp, StackPointerFromContext(&context_2));
@@ -145,10 +139,7 @@ void TestCaptureContext() {
}
TEST(CaptureContextMac, CaptureContext) {
- TestCaptureContext();
- if (Test::HasFatalFailure()) {
- return;
- }
+ ASSERT_NO_FATAL_FAILURE(TestCaptureContext());
}
} // namespace
« no previous file with comments | « no previous file | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698