Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 639123008: [MIPS] Define 'CPU_CISC' for mips as aes calculation is incorrect for 'CPU_RISC' (Closed)

Created:
6 years, 2 months ago by gordanac
Modified:
6 years, 1 month ago
CC:
petar.jovanovic, Paul Lind
Visibility:
Public.

Description

[MIPS] Define 'CPU_CISC' for mips as aes calculation is incorrect for 'CPU_RISC' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292694

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M libsrtp.gyp View 1 2 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gordanac
Please take a look. Similar change was made for arm quite some time ago: https://codereview.chromium.org/9956068
6 years, 2 months ago (2014-10-17 15:28:34 UTC) #2
gordanac
On 2014/10/17 15:28:34, gordanac wrote: > Please take a look. > > Similar change was ...
6 years, 2 months ago (2014-10-21 10:10:23 UTC) #5
gordanac
Ping.
6 years, 2 months ago (2014-10-24 10:44:33 UTC) #6
Mallinath (Gone from Chromium)
small nit, otherwise lgtm https://codereview.chromium.org/639123008/diff/1/libsrtp.gyp File libsrtp.gyp (right): https://codereview.chromium.org/639123008/diff/1/libsrtp.gyp#newcode52 libsrtp.gyp:52: # TODO(leozwang): CPU_RISC doesn't work ...
6 years, 2 months ago (2014-10-24 16:14:56 UTC) #7
gordanac
Addressing comment.
6 years, 1 month ago (2014-10-28 09:17:53 UTC) #8
gordanac
https://codereview.chromium.org/639123008/diff/1/libsrtp.gyp File libsrtp.gyp (right): https://codereview.chromium.org/639123008/diff/1/libsrtp.gyp#newcode52 libsrtp.gyp:52: # TODO(leozwang): CPU_RISC doesn't work properly on android/arm and ...
6 years, 1 month ago (2014-10-28 09:19:08 UTC) #9
gordanac
I don't think Commit queue is going to work but I will give it a ...
6 years, 1 month ago (2014-10-28 09:20:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639123008/20001
6 years, 1 month ago (2014-10-28 09:21:44 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 09:22:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 292694

Powered by Google App Engine
This is Rietveld 408576698